[wp-trac] [WordPress Trac] #53599: WP_Theme::get_files() returns unexpected entry if parent theme not available.

WordPress Trac noreply at wordpress.org
Mon Apr 25 09:45:16 UTC 2022


#53599: WP_Theme::get_files() returns unexpected entry if parent theme not
available.
-------------------------------------------------+-------------------------
 Reporter:  dd32                                 |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.0
Component:  Themes                               |     Version:
 Severity:  minor                                |  Resolution:  fixed
 Keywords:  good-first-bug has-patch has-unit-   |     Focuses:
  tests commit assigned-for-commit               |
-------------------------------------------------+-------------------------
Changes (by audrasjb):

 * status:  reviewing => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53253" 53253]:
 {{{
 #!CommitTicketReference repository="" revision="53253"
 Themes: Ensure `WP_Theme::get_files()` doesn't return unexpected values.

 This change filters out empty entries from `WP_Theme::get_files()` before
 returning the array of files. This avoid returning an entry with `false`
 value when the directory of the theme does not exist.

 Props dd32, opurockey, Rahmohn, audrasjb.
 Fixes #53599.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53599#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list