[wp-trac] [WordPress Trac] #47968: Feed (with comments) Last-Modified header only considers latest comment date

WordPress Trac noreply at wordpress.org
Wed Apr 20 12:46:17 UTC 2022


#47968: Feed (with comments) Last-Modified header only considers latest comment
date
-------------------------------------------------+-------------------------
 Reporter:  xiven                                |       Owner:  audrasjb
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.0
Component:  Feeds                                |     Version:  5.2.2
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch has-unit-tests commit      |     Focuses:
  assigned-for-commit                            |
-------------------------------------------------+-------------------------
Changes (by audrasjb):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53233" 53233]:
 {{{
 #!CommitTicketReference repository="" revision="53233"
 Feeds: Use latest comment date for the `Last-Modified` header of comments
 feed.

 Previously, the `Last-Modified` header of comments feed was using the
 date/time of the last comment. This behavior was breaking caching and
 causing feed readers to believe there is no new content even when there
 might be new posts.

 This commit changes this behavior to use the newest date from both
 `get_lastcommentmodified()` and `get_lastpostmodified()` functions instead
 of only using the result from `get_lastcommentmodified()`.

 Props xiven, mauteri, costdev, audrasjb.
 Fixes #47968.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/47968#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list