[wp-trac] [WordPress Trac] #54257: tests for is_php_version_compatible and is_wp_version_compatible

[WordPress Trac]

#54257: tests for is_php_version_compatible and is_wp_version_compatible
--------------------------------------+-----------------------
 Reporter:  pbearne                   |       Owner:  pbearne
     Type:  task (blessed)            |      Status:  reopened
 Priority:  normal                    |   Milestone:  6.0
Component:  Build/Test Tools          |     Version:  5.2
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------
Changes (by costdev):

 * keywords:  has-patch has-unit-tests dev-feedback => has-patch has-unit-
     tests
 * resolution:  fixed =>
 * status:  closed => reopened
 * component:  Plugins => Build/Test Tools
 * type:  defect (bug) => task (blessed)


Comment:

 Patch
 [https://core.trac.wordpress.org/attachment/ticket/54257/54257.1.diff
 54257.1.diff] updates the tests introduced in [53227] to:

 - fix an incorrect function name in the documentation.
 - use consistent documentation within the test suite.
 - improve readability.
 - remove spaces between increment/decrement operators per
 [https://make.wordpress.org/core/2020/03/20/updating-the-coding-standards-
 for-modern-php/ proposed coding standards changes].
 - use informative argument and variable names.
 - add `public` visibility to the data providers.
 - add tests to cover falsey values.
 - add tests to cover `alpha` and `beta` versions.
 - remove an unnecessary call to `get_bloginfo()`, as this simply returns
 the value of `$wp_version`.

 In addition:
 - Changing this from `bug (defect)` to `task (blessed)` as it is a tests-
 only ticket.
 - Changing this from the `Plugins` component to `Build/Test Tools`:
   - These functions can be used with respect to both plugins and themes.
   - Tests are within the scope of Test Tools.
   - This helps with queries to find test-only tickets, whereas the `has-
 unit-tests` keyword can be applied to any ticket.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54257#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform