[wp-trac] [WordPress Trac] #54825: Heartbeat minimalInterval option causing incorrect value of mainInterval

[WordPress Trac]

#54825: Heartbeat minimalInterval option causing incorrect value of mainInterval
-------------------------------------------------+-------------------------
 Reporter:  tabrisrp                             |       Owner:
                                                 |  peterwilsoncc
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  6.0
Component:  Autosave                             |     Version:
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  has-patch needs-testing dev-         |     Focuses:  javascript
  reviewed                                       |
-------------------------------------------------+-------------------------
Changes (by peterwilsoncc):

 * owner:  (none) => peterwilsoncc
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"53226" 53226]:
 {{{
 #!CommitTicketReference repository="" revision="53226"
 Autosave: Compare heartbeat intervals in same unit.

 Move the conversion of `minimalInterval` to milliseconds to be grouped
 with the other time conversions from seconds to milliseconds.

 This fixes a bug in which the minimal and main intervals were compared
 after the former had been converted to milliseconds but the latter had
 not. This could cause the heatbeat interval to blow out to unexpectedly
 high values if the minimal interval was set.

 Props tabrisrp, sabernhardt, SergeyBiryukov, audrasjb.
 Fixes #54825.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54825#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform