[wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0

[WordPress Trac]

#55327: PHP 8.0: improvements to allow for named parameters in WP 6.0
-----------------------------+---------------------
 Reporter:  peterwilsoncc    |       Owner:  (none)
     Type:  task (blessed)   |      Status:  new
 Priority:  normal           |   Milestone:  6.0
Component:  General          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  php80 has-patch  |     Focuses:
-----------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"53220" 53220]:
 {{{
 #!CommitTicketReference repository="" revision="53220"
 Code Modernization: Rename parameters that use reserved keywords in `wp-
 admin/includes/template.php`.

 While using reserved PHP keywords as parameter name labels is allowed, in
 the context of function calls using named parameters in PHP 8.0+, this
 will easily lead to confusion. To avoid that, it is recommended not to use
 reserved keywords as function parameter names.

 This commit:
 * Renames the `$echo` parameter to `$display` in:
  * `wp_popular_terms_checklist()`
  * `_post_states()`
  * `_media_states()`
 * Renames the `$default` parameter to `$default_term` in
 `wp_popular_terms_checklist()`.
 * Renames the `$default` parameter to `$default_template` in
 `page_template_dropdown()`.
 * Renames the `$default` parameter to `$default_page` in
 `parent_dropdown()`.
 * Renames the `$object` parameter to `$data_object` in:
  * `do_block_editor_incompatible_meta_box()`
  * `do_meta_boxes()`
  * `do_accordion_sections()`
 * Amends the `$item_object` parameter in other functions for consistency:
  * `wp_nav_menu_item_post_type_meta_box()`
  * `wp_nav_menu_item_taxonomy_meta_box()`
  * `_wp_nav_menu_meta_box_object()`

 Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
 [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
 [53192], [53193], [53198], [53203], [53207], [53215], [53216].

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #55327.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform