[wp-trac] [WordPress Trac] #55327: PHP 8.0: improvements to allow for named parameters in WP 6.0

[WordPress Trac]

#55327: PHP 8.0: improvements to allow for named parameters in WP 6.0
-----------------------------+---------------------
 Reporter:  peterwilsoncc    |       Owner:  (none)
     Type:  task (blessed)   |      Status:  new
 Priority:  normal           |   Milestone:  6.0
Component:  General          |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  php80 has-patch  |     Focuses:
-----------------------------+---------------------

Comment (by SergeyBiryukov):

 In [changeset:"53215" 53215]:
 {{{
 #!CommitTicketReference repository="" revision="53215"
 Code Modernization: Rename parameters that use reserved keywords in `wp-
 admin/includes/plugin.php`.

 While using reserved PHP keywords as parameter name labels is allowed, in
 the context of function calls using named parameters in PHP 8.0+, this
 will easily lead to confusion. To avoid that, it is recommended not to use
 reserved keywords as function parameter names.

 This commit:
 * Renames the `$function` parameter to `$callback` in:
  * `add_menu_page()`
  * `add_submenu_page()`
  * `add_management_page()`
  * `add_options_page()`
  * `add_theme_page()`
  * `add_plugins_page()`
  * `add_users_page()`
  * `add_dashboard_page()`
  * `add_posts_page()`
  * `add_media_page()`
  * `add_links_page()`
  * `add_pages_page()`
  * `add_comments_page()`
 * Renames the `$echo` parameter to `$display` in `menu_page_url()`.
 * Renames the `$parent` parameter to `$parent_page` in
 `get_admin_page_parent()`.

 Follow-up to [52946], [52996], [52997], [52998], [53003], [53014],
 [53029], [53039], [53116], [53117], [53137], [53174], [53184], [53185],
 [53192], [53193], [53198], [53203], [53207].

 Props jrf, aristath, poena, justinahinon, SergeyBiryukov.
 See #55327.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/55327#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform