[wp-trac] [WordPress Trac] #45438: All Settings page (options.php), message when saved

[WordPress Trac]

#45438: All Settings page (options.php), message when saved
-------------------------------------------------+-------------------------
 Reporter:  ishitaka                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  enhancement                          |      Status:  reviewing
 Priority:  normal                               |   Milestone:  6.0
Component:  Options, Meta APIs                   |     Version:
 Severity:  minor                                |  Resolution:
 Keywords:  good-first-bug needs-testing has-    |     Focuses:
  patch                                          |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 [attachment:"45438.2.patch"] looks good, [attachment:"45438.diff"] is
 identical with a minor coding standards fix.

 Testing notes

 **System**
 WordPress 6.0-alpha-52448-src
 PHP-FPM 7.4
 nginx

 PHP Config: `max_input_vars` set to `10`.

 **Before**
 * Saving `wp-admin/options.php` shows as successful
 * Database did not update due to exceeding `max_input_vars`

 **After**
 * Saving `wp-admin/options.php` shows an error message
 * Behaviour unchanged after removing change to `max_input_vars`

 ✓ working as expected

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/45438#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform