[wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js

WordPress Trac noreply at wordpress.org
Mon Apr 11 01:18:11 UTC 2022

#55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js
 Reporter:  SergeyBiryukov        |       Owner:  joedolson
     Type:  enhancement           |      Status:  accepted
 Priority:  normal                |   Milestone:  6.0
Component:  Administration        |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  has-patch needs-      |     Focuses:  accessibility, javascript
  testing                         |

Comment (by peterwilsoncc):

 Replying to [comment:20 joedolson]:
 > For the record, I think that the tests failure is in some way related to
 changing the shape of the AJAX response, and that leaving the parameter in
 the response is the best solution here, but I can't find a definite answer
 to that in the unit tests.

 I agree, removing it is an unnecessary backward compatibility break that
 may affect more than WordPress Core. Changing the shape by removing the
 data ought to happen on a dedicated ticket.

 Given `data` needs to remain, I'd be inclined to leave it out of
 `supplemental` for now.

 If the variable is to be renamed, I suggest `noticeMessage` for both
 observing coding standards and clarity.

Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list