[wp-trac] [WordPress Trac] #54742: Fix GHA on first runs for new branches
WordPress Trac
noreply at wordpress.org
Fri Apr 8 13:57:58 UTC 2022
#54742: Fix GHA on first runs for new branches
------------------------------+-----------------------
Reporter: davidbaumwald | Owner: desrosj
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 6.0
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
------------------------------+-----------------------
Comment (by desrosj):
In [changeset:"53108" 53108]:
{{{
#!CommitTicketReference repository="" revision="53108"
Build/Test Tools: Improve the accuracy of “fixed” Slack notifications.
This adjusts the logic of the Slack Notifications workflow to make the
“fixed” notifications more reliable.
Currently, the workflow looks at the immediately preceding workflow run
for the current branch. This fails to indicate that a workflow is fixed
when other unrelated commits are made, and when rerunning the workflow
after a false failure (timeout, etc.).
The workflow will now use the following logic to determine if something
has been fixed:
- When a workflow is rerun, the conclusion for the immediately preceding
run attempt will now be used to determine if the current attempt has
“fixed” the workflow.
- When on the first run attempt for a workflow run, the workflow
conclusion for the immediately preceding commit will be used.
- When on the first run attempt for a workflow run and no preceding
commits for the current branch are present (this is a fresh tag or
branch), always consider it “fixed”.
Props davidbaumwald.
See #54742.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54742#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list