[wp-trac] [WordPress Trac] #55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js
WordPress Trac
noreply at wordpress.org
Sun Apr 3 20:14:53 UTC 2022
#55078: Remove hardcoded check for edit-tags.php from lib/ajax-response.js
----------------------------------+----------------------------------------
Reporter: SergeyBiryukov | Owner: joedolson
Type: enhancement | Status: accepted
Priority: normal | Milestone: 6.0
Component: Administration | Version:
Severity: normal | Resolution:
Keywords: has-patch needs- | Focuses: accessibility, javascript
testing |
----------------------------------+----------------------------------------
Comment (by joedolson):
I'm not seeing why removing `data` from that array is triggering a tests
failure, either.
Looks like it can be set to empty, since it's overridden in the response.
It certainly feels like it should be omittable if it's going to be empty,
but since it's a default argument, the handler will put it back in the
array in the `add` method. So in aggregate, I don't think there's any
benefit to omitting the argument.
Might need a comment to explain the duplication and/or omission, however,
unless we identify why the test is failing.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55078#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list