[wp-trac] [WordPress Trac] #55433: Twenty Twenty-Two: Implement alternate json files
WordPress Trac
noreply at wordpress.org
Fri Apr 1 15:57:59 UTC 2022
#55433: Twenty Twenty-Two: Implement alternate json files
---------------------------------------------+---------------------
Reporter: kjellr | Owner: (none)
Type: enhancement | Status: new
Priority: normal | Milestone: 6.0
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: needs-design-feedback has-patch | Focuses:
---------------------------------------------+---------------------
Comment (by kjellr):
Hi everyone! Here's an update on these style directions:
I've gone in and made some color adjustments in order to pull these apart
from each other just a bit more. The red one now has red text throughout,
and the pink one has been made more distinct from the cyan one. In
addition, each one has been revised to include some spacing and block
style modifications in addition to the color and font changes. As a
result, these each feel just a tiny bit more unique.
The differences between each of these feel pretty noticeable when
switching in the editor, so here's a video of that state:
https://cloudup.com/cAqPsRiP7jZ
Here are some example screenshots as well:
[[Image(https://cldup.com/oPbijC7ike.png)]]
[[Image(https://cldup.com/yI3wyTEdwp.png)]]
[[Image(https://cldup.com/IpUFugLvJe.png)]]
---
The major hurdles for the moment remain the same as I mentioned above:
- Webfonts declared in styles variants are not loaded:
https://github.com/WordPress/gutenberg/issues/39702
- Duotone does not render in the site editor:
https://github.com/WordPress/gutenberg/issues/35331
The Duotone issues appear to be fixed in
[https://github.com/WordPress/gutenberg/pull/37727 the associated PR]. The
fonts issues are also fixed
[https://github.com/WordPress/gutenberg/pull/39886 in their PR], but they
seem to be a little flaky in my testing — sometimes they load and other
times they don't. The screenshots above were all taken while running both
of those PRs together, but the fonts are falling back to my local copies
instead of the theme versions.
I could use help from a few angles:
1. Testing and code reviews. Are there any mistakes in the JSON? Can you
spot any additional settings from the original that I need to be
overriding in the variations?
2. Testing against those PRs. Specifically the fonts one. I'm not sure if
the issues I'm seeing are specifically related to my test environment or
not.
3. Design suggestions: Do these directions feel distinct enough? Is each
one strong individually? What we can we do to pull them apart even more?
Thanks for taking a look!
--
Ticket URL: <https://core.trac.wordpress.org/ticket/55433#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list