[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early has-testing-info needs-patch   |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------

Comment (by aristath):

 Replying to [comment:138 peterwilsoncc]:
 > @aristath I did a `git bisect` on a copy of the built version of WP and
 was getting the timeout with a checkout of [51815]'s equivalent
 ([https://github.com/WordPress/WordPress/commit/dcca93232b0ae5689b0ec5d88ac68405b9114ac8
 dcca9323 on git's built version]) but not with [51814]'s equivalent
 ([https://github.com/WordPress/WordPress/commit/a13f7b31cd5d383dea01b2d5dffd5f038cd225ef
 a13f7b31 on git's built version]).
 >
 > I just retested on the built version with [51815]'s equivalent
 `dcca9323` reverted and wasn't getting any timeouts or fatal errors. I
 tested with gutenberg, akismet and wpforms-lite. I reconfirmed the
 timeouts & fatals with the most recent commit, [51876].

 Using `git-bisect` I'm also getting the same results, but here's the
 weirdness I currently see on my localhost:
 * If I rollback to before this commit, updates succeed.
 * With this commit, updates fail
 * If I pull the latest changes from master and then **revert** this
 commit, updates fail.

 That last bullet-point is what makes me believe this regression is not
 100% caused by the commit on this ticket, and there's maybe more things to
 consider. If this commit was to blame, then reverting it on the current
 develop branch ''should'' fix it, and it does not. 🤔

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:143>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform