[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early has-testing-info needs-patch   |     Focuses:
  needs-unit-tests                               |
-------------------------------------------------+-------------------------

Comment (by peterwilsoncc):

 @aristath I did a `git bisect` on a copy of the built version of WP and
 was getting the timeout with a checkout of [51815]'s equivalent
 ([https://github.com/WordPress/WordPress/commit/dcca93232b0ae5689b0ec5d88ac68405b9114ac8
 dcca9323 on git's built version]) but not with [51814]'s equivalent
 ([https://github.com/WordPress/WordPress/commit/a13f7b31cd5d383dea01b2d5dffd5f038cd225ef
 a13f7b31 on git's built version]).

 I just retested on the built version with [51815]'s equivalent `dcca9323`
 reverted and wasn't getting any timeouts or fatal errors. I tested with
 gutenberg, akismet and wpforms-lite. I reconfirmed the timeouts & fatals
 with the most recent commit, [51876].

 As with earlier testing, I was using the "Dashboard > Updates > view
 version ### details > install update now" workflow to update the plugins.
 My local environment is using the `WP_Filesystem_Direct`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:138>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform