[wp-trac] [WordPress Trac] #54191: There is no comment for the initialize function

WordPress Trac noreply at wordpress.org
Mon Sep 27 20:00:02 UTC 2021


#54191: There is no comment for the initialize function
-------------------------------------+-------------------------------
 Reporter:  yagniksangani            |       Owner:  (none)
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Toolbar                  |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:  coding-standards
-------------------------------------+-------------------------------
Changes (by audrasjb):

 * keywords:  needs-patch => has-patch needs-refresh


Comment:

 Thanks for the patch!

 Aside from Tonya’s comments, I'd add another thing to note: it's better to
 generate the diff file in the `wordpress-develop` folder because that's
 easier for other people to apply your patch on their side. On this
 particular patch, that's not an issue but it can make things harder to
 test for future ones :-)

 (so in your case, the path of the file will be `src/wp-includes/class-wp-
 admin-bar.php` rather than `wp-includes/class-wp-admin-bar.php`)

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54191#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list