[wp-trac] [WordPress Trac] #54183: Tests: decide on how to handle deprecations in PHPUnit

[WordPress Trac]

#54183: Tests: decide on how to handle deprecations in PHPUnit
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.9
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-dev-note php81 has-patch has-  |     Focuses:
  unit-tests commit                              |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 In [changeset:"51872" 51872]:
 {{{
 #!CommitTicketReference repository="" revision="51872"
 Tests: Update the `Services_JSON` test for PHPUnit 9.5.10/8.5.21+.

 Since PHPUnit 9.5.10 and 8.5.21, PHP deprecations are no longer converted
 to exceptions by default (`convertDeprecationsToExceptions="true"` can be
 configured to enable this).

 Reference:
 [https://github.com/sebastianbergmann/phpunit/commit/fac02620f6b38ae54d47fe840e0095e68226a56c
 Do not convert PHP deprecations to exceptions by default];
 [https://github.com/sebastianbergmann/phpunit/blob/9.5.10/ChangeLog-9.5.md#9510
 ---2021-09-25 PHPUnit 9.5.10 changelog].

 With this change, the test for the `Services_JSON` compat class started
 failing:
 {{{
 There was 1 failure:

 1) Tests_Compat_jsonEncodeDecode::test_json_encode_decode
 Failed asserting that exception of type
 "PHPUnit\Framework\Error\Deprecated" is thrown.
 }}}

 This converts the native PHPUnit `::expectDeprecation()` method call in
 the test to a set of individual WP-specific `::setExpectedDeprecated()`
 method calls in order to not depend on PHPUnit behavior that is no longer
 the default.

 Additionally, this commit includes support for catching deprecation
 notices from `_deprecated_file()` function calls to the
 `WP_UnitTestCase_Base::expectDeprecated()` method.

 Follow-up to [46205], [46625], [48996], [51563], [51852], [51871].

 Props jrf, netweb, SergeyBiryukov.
 See #54183, #54029, #53363.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54183#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform