[wp-trac] [WordPress Trac] #54183: Tests: decide on how to handle deprecations in PHPUnit

WordPress Trac noreply at wordpress.org
Sat Sep 25 17:34:29 UTC 2021


#54183: Tests: decide on how to handle deprecations in PHPUnit
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:  (none)
     Type:  task (blessed)                       |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  needs-patch 2nd-opinion needs-dev-   |     Focuses:
  note php81                                     |
-------------------------------------------------+-------------------------

Comment (by costdev):

 **Option 1**
 If there's a lot of deprecation notices, but the CI still passes, the
 notices will likely be unnoticed/ignored. As the next major would result
 in errors, we'd ultimately just be delaying the inevitable and increasing
 our workload when the time comes.

 **Option 2**
 Reverting to previous behaviour keeps things consistent with contributor
 experience. It's worth doing, but it's a shame that only the first notice
 shows.

 **Option 3**
 This is the best option IMHO, but requires some work to resolve risky
 tests in Core.

 We could do a review of risky tests to get an idea of the work involved in
 implementing Option 3. Until it's implemented, I'd suggest that we
 implement Option 2 as soon as possible to prevent any deprecations making
 their way into Core.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54183#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list