[wp-trac] [WordPress Trac] #53924: Press escape to close Attachment details on media upload page

WordPress Trac noreply at wordpress.org
Sat Sep 18 21:37:10 UTC 2021


#53924: Press escape to close Attachment details on media upload page
--------------------------+----------------------------------------
 Reporter:  vondelphia    |       Owner:  joedolson
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  5.9
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  accessibility, javascript
--------------------------+----------------------------------------
Changes (by sabernhardt):

 * focuses:  accessibility => accessibility, javascript


Comment:

 Thanks for the patch! With that, I was able to use the Escape key more
 than once.

 We probably should edit the note above that line, too, because it does not
 remove restricted focus anymore. An
 [https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/media-
 views.js?rev=28607#L3129 earlier version of the script] used a different
 method to keep focus inside the media modal, until r29220.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53924#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list