[wp-trac] [WordPress Trac] #53635: PHP 8.1: various compatibility fixes

WordPress Trac noreply at wordpress.org
Wed Sep 15 21:22:13 UTC 2021


#53635: PHP 8.1: various compatibility fixes
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php81 has-patch has-unit-tests       |     Focuses:  coding-
  commit                                         |  standards
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"51817" 51817]:
 {{{
 #!CommitTicketReference repository="" revision="51817"
 Build/Test Tools: Reworks `Tests_Option_Option::test_bad_option_names()`
 into data provider.

 The existing tests were running multiple functions through a `foreach()`.
 If any test failed, it would bail out and not test against the other
 scenarios.

 This commit:

 - Moves the scenarios to a data provider with named data sets, i.e. to
 ensure all scenarios are run and tested regardless if any fail.
 - Splits each function under test into individual test methods.
 - Adds a float scenario.
 - Adds method visibility modifiers.

 Follow-up to [25002].

 Props jrf, hellofromTonya, pbearne.
 See #53635.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53635#comment:112>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list