[wp-trac] [WordPress Trac] #46149: PHPUnit 8.x support

WordPress Trac noreply at wordpress.org
Tue Sep 14 18:48:00 UTC 2021


#46149: PHPUnit 8.x support
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:  jrf
     Type:  task (blessed)                       |      Status:  assigned
 Priority:  high                                 |   Milestone:  5.9
Component:  Build/Test Tools                     |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests early php8  |     Focuses:
  needs-dev-note                                 |
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"51812" 51812]:
 {{{
 #!CommitTicketReference repository="" revision="51812"
 Build/Test Tools: Improve messaging when PHPUnit Polyfills do not comply
 with version requirements.

 Previously, two situations were taken in to account:
 1. The `WP_TESTS_PHPUNIT_POLYFILLS_PATH` constant is defined => just show
 a message about the version mismatch.
 2. The constant is not defined => show a message to run `composer update`.
 This message is intended for people trying to run the WP Core tests.

 This could lead to an unclear situation for people trying to run
 plugin/theme integration tests without the new
 `WP_TESTS_PHPUNIT_POLYFILLS_PATH` constant being defined.

 They could be shown the message to run `composer update` while if they
 would do so for their local install without adding the Polyfills, the
 message would still display the next time they would attempt to run the
 tests.

 This commit:
 1. Provides more information about the PHPUnit Polyfills version detected
 vs the version expected.
 2. Shows a more specific message to guide users which have the
 `WP_TESTS_PHPUNIT_POLYFILLS_PATH` constant declared.
 3. Only shows the message to run `composer update` when the
 `WP_RUN_CORE_TESTS` constant is declared to prevent confusing people more.

 Follow-up to [51598], [51810], [51811].

 Props jrf, schlessera, hellofromTonya, jeherve, lucatume.
 See #46149.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/46149#comment:134>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list