[wp-trac] [WordPress Trac] #53635: PHP 8.1: various compatibility fixes

[WordPress Trac]

#53635: PHP 8.1: various compatibility fixes
-------------------------------------------------+-------------------------
 Reporter:  SergeyBiryukov                       |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  accepted
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php81 has-patch has-unit-tests       |     Focuses:  coding-
  commit                                         |  standards
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"51797" 51797]:
 {{{
 #!CommitTicketReference repository="" revision="51797"
 Code Modernization: Fix null to non-nullable deprecations in
 `WP_Meta_Query::get_sql_for_clause()`.

 In the `WP_Meta_Query::get_sql_for_clause()`, the `'value'` index from a
 meta query array is passed to the PHP native `trim()` function without
 prior validation.

 In PHP 8.1, this could lead to a `trim(): Passing null to parameter #1
 ($string) of type string is deprecated` notice.

 `trim()` expects a text string and is only useful when ''passed'' a text
 string as no other variable type can contain whitespace.

 Fixed now by verifying that the ''value'' is a string before processing it
 with `trim()`.

 This issue is already covered by the existing
 `Tests_Meta_Query::test_null_value_sql()` and the
 `Tests_Meta_Query::test_convert_null_value_to_empty_string()` tests.

 Follow-up to [17699], [29887], [29940].

 Props jrf, hellofromTonya.
 See #53635.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53635#comment:96>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform