[wp-trac] [WordPress Trac] #51553: PHP 8.0: code improvements to allow for named parameters in function calls

WordPress Trac noreply at wordpress.org
Thu Sep 9 20:13:13 UTC 2021


#51553: PHP 8.0: code improvements to allow for named parameters in function calls
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch needs-codex early     |     Focuses:  coding-
  needs-dev-note commit                          |  standards
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"51789" 51789]:
 {{{
 #!CommitTicketReference repository="" revision="51789"
 Code Modernization: Fix parameter name mismatches for parent/child classes
 in `WP_Widget::update()`.

 In each child class, renames the parameter to match the parent's method
 signature.
 Why? PHP 8 introduces the ability to pass named arguments to
 function/method calls. This means the child and parent method signatures
 (i.e. parameter names) need to match.

 Adds @since to clearly specify why the change happened.

 Replaces the original with the variable name with within each method.
 Why? The new name is more specific and descriptive, which improves
 readability.

 Follow-up to [10782], [25090], [26556], [40640].

 Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
 See #51553.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51553#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list