[wp-trac] [WordPress Trac] #51553: PHP 8.0: code improvements to allow for named parameters in function calls

[WordPress Trac]

#51553: PHP 8.0: code improvements to allow for named parameters in function calls
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  hellofromTonya
     Type:  task (blessed)                       |      Status:  reviewing
 Priority:  normal                               |   Milestone:  5.9
Component:  General                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  php8 has-patch needs-codex early     |     Focuses:  coding-
  needs-dev-note commit                          |  standards
-------------------------------------------------+-------------------------

Comment (by hellofromTonya):

 In [changeset:"51781" 51781]:
 {{{
 #!CommitTicketReference repository="" revision="51781"
 Code Modernization: Fix reserved keyword and parameter name mismatches for
 parent/child classes in `WP_Upgrader_Skin::feedback()`.

 In the parent class, renames the parameter `$string` to `$feedback`.
 Why? `string` is a PHP reserved keyword.

 In each child class: renames the parameter to match the parent's method
 signature.

 Why? PHP 8 introduces the ability to pass named arguments to
 function/method calls. This means the child and parent method signatures
 (i.e. parameter names) need to match.

 Changes for readability:

 - `@since` clearly specifies the original parameter name and its new name
 as well as why the change happened.

 Follow-up to [11005], [25228], [30680], [32655], [38199], [49596].

 Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
 See #51553.
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51553#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform