[wp-trac] [WordPress Trac] #53801: Block-based Widgets Screen does action wp_footer after each Widget

[WordPress Trac]

#53801: Block-based Widgets Screen does action wp_footer after each Widget
-------------------------------------+---------------------
 Reporter:  MadtownLems              |       Owner:  (none)
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  5.8.2
Component:  Widgets                  |     Version:  5.8
 Severity:  major                    |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+---------------------

Comment (by costdev):

 @ryokuhi Thanks a lot for this feedback!

 > A possible unexpected result of hiding non-widget elements is that, in
 case the widget requires some content located in the footer (for example,
 if the widget triggers a modal contained in wp_footer), it would be
 impossible to replicate that behaviour in preview mode. We don't know of
 any specific example of such an implementation and this wouldn't be an
 accessibility issue, but it's worth taking in consideration such a
 possibility.

 I agree that there are a number of edge cases that may be encountered -
 This presents a negative both in the existing release of Core (a modal
 appearing within the legacy widget preview may be larger than the preview
 container) and in the fix for the issue this ticket raises (no visible
 modal at all).

 @eatingrules
 > I just tested the patch on a site that was having these issues and it
 worked well. It hid three different script-based items that were getting
 in the way.🎉

 Excellent!

 I think that the remainder of your comment highlights where the scope of
 this ticket and legacy widget preview feedback diverge. The current patch,
 with some adjustments as mentioned in an earlier comment I posted, appears
 to present a workable solution to the issue that this ticket raises. Our
 edge cases are for now hypothetical in the wild - however, I'm itching to
 find one! - I think this ticket is possibly coming to a close soon after
 some additional testing.

 With regards to the future of legacy widget previews, I think an option to
 disable legacy widget previews is the best way forward. However, this
 should be raised in another ticket, probably as an `enhancement`, tagging
 `ui`, `accessibility` and `admin` to get some well-rounded input on this.
 If you're interested in raising the ticket and want to discuss anything
 about it beforehand, feel free to DM me on Slack.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53801#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform