[wp-trac] [WordPress Trac] #53945: Local test workflow changes for installing Composer dependencies

[WordPress Trac]

#53945: Local test workflow changes for installing Composer dependencies
------------------------------------------------+--------------------------
 Reporter:  hellofromTonya                      |       Owner:  johnbillion
     Type:  task (blessed)                      |      Status:  reopened
 Priority:  normal                              |   Milestone:  5.9
Component:  Build/Test Tools                    |     Version:
 Severity:  normal                              |  Resolution:
 Keywords:  has-patch has-testing-instructions  |     Focuses:
------------------------------------------------+--------------------------

Comment (by azaozz):

 Replying to [comment:32 jrf]:
 > The delay happening **after** the "composer fund" to me indicates that
 this has nothing to do with Composer as Composer is already finished by
 then.

 Right, but it is caused by running `composer update -W` that was added in
 [51685]. If that is not run, there is no delay.

 > If I remember correctly, I believe @johnbillion also mentioned something
 about running the tests via Docker being significantly slower
 (independently of this change and before this change was even made). He
 also mentioned a time difference of ~3 minutes.

 Right, it is slower, by about 1.5 min here. As far as I understand this is
 caused by running from a Docker container vs. directly in the OS. All of
 WP runs a bit slower. That's not the same as the delay after `composer
 update` finishes and before `phpunit --group 12345` starts.

 > The ~3 minute delay sounds like a 180 second process timeout, so I
 wonder whether there is something going on in Docker

 Yeah, could be. I'm not that good at debugging Docker, but will try
 looking more there.

 My other point was that it doesn't make sense to run `composer update -W`
 every time when doing `npm run test:php`. When working on tests the same
 test case is usually run repeatedly, so checking for Composer updates
 20-30 times per hour is not good.

 For that reason I think that part of [51685] should be reverted. Perhaps
 another method can be found to ensure Composer updates are run from time
 to time, or that can be a documented step like with npm updates.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53945#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform