[wp-trac] [WordPress Trac] #28117: Admin bar shouldn't use dynamic styles on frontend for logged out visitors

WordPress Trac noreply at wordpress.org
Thu Sep 2 19:50:51 UTC 2021


#28117: Admin bar shouldn't use dynamic styles on frontend for logged out visitors
-------------------------------------------------+-------------------------
 Reporter:  dimadin                              |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
                                                 |  Review
Component:  Toolbar                              |     Version:  3.3
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing needs-       |     Focuses:
  testing-info                                   |  administration
-------------------------------------------------+-------------------------
Changes (by sabernhardt):

 * keywords:  has-patch needs-testing => has-patch needs-testing needs-
     testing-info


Comment:

 28117.1.patch still applies, but I have not tested it properly with a
 caching plugin.

 A good testing procedure could help, and below is a basic outline (I'm
 sure I have missed something):
 - Before applying the patch, we would want to set up page caching, then
 visit on a mobile device and verify the 'mobile' class is used, then visit
 again on a desktop and see that the class is still there.
 - After applying the patch, purge the cache, then visit on mobile again to
 save the mobile version, and visit on a desktop to verify that it does
 ''not'' show the mobile version.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/28117#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list