[wp-trac] [WordPress Trac] #53811: Rename `retrieve_widgets` to `sync_registered_widgets`

[WordPress Trac]

#53811: Rename `retrieve_widgets` to `sync_registered_widgets`
-------------------------------------------------+-------------------------
 Reporter:  zieladam                             |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Widgets                              |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests commit      |     Focuses:
  fixed-major                                    |
-------------------------------------------------+-------------------------
Changes (by azaozz):

 * milestone:  5.8.2 => 5.9


Comment:

 As far as I know only (major) bug fixes and regression fixes belong in dot
 releases. There are two reasons:
 1. Dot releases are usually not tested as thoroughly as major releases.
 The risks of introducing a bug and deploying it across millions of
 installs should be minimized as much as possible.
 2. The autoupdate failures rate slightly increases when the update is
 larger/has more files. That increase is very small as a percentage but
 given the size of WP it translates into thousands or tens of thousands of
 installs.

 In that terms moving to 5.9 for further consideration.

 > The name is misleading and it bit us in
 https://github.com/WordPress/gutenberg/issues/33335#issuecomment-879903958
 and #53657.

 Perhaps a better way to fix this would be to extend and enhance the inline
 docs. Would be great to add some inline comments too. True, the new name
 is better than the old, but at the same time that function does a lot of
 things and the name will never be able to describe it particularly well.
 Also renaming and deprecating a function has some downsides like filling
 the PHP error logs with deprecation warnings on thousands of servers.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53811#comment:26>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform