[wp-trac] [WordPress Trac] #53811: Rename `retrieve_widgets` to `sync_registered_widgets`
WordPress Trac
noreply at wordpress.org
Wed Sep 1 15:55:20 UTC 2021
#53811: Rename `retrieve_widgets` to `sync_registered_widgets`
---------------------------------------------+-----------------------------
Reporter: zieladam | Owner: hellofromTonya
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.8.2
Component: Widgets | Version:
Severity: normal | Resolution:
Keywords: has-patch has-unit-tests commit | Focuses:
---------------------------------------------+-----------------------------
Changes (by desrosj):
* milestone: 5.8.1 => 5.8.2
Comment:
Some thoughts on [51705]:
- Deprecated functions are supposed to be moved to `deprecated.php`.
However, I'd like to confirm whether "soft" deprecations have also been
moved here in the past, or if the precedent is to leave them in their
original place.
- While this does seem to make things more clear, I agree with
@TimothyBlynJacobs that it's borderline
[https://make.wordpress.org/core/handbook/contribute/code-refactoring/
refactoring for the sake of refactoring].
This isn't actually ''fixing'' anything as it pertains to the user. It's
changing a function name in order to make it more clear to developers. So
I'm inclined to agree it should wait till 5.9, or at least have more
discussion before being reconsidered for 5.8.2.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/53811#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list