[wp-trac] [WordPress Trac] #53710: WP Update notice shown twice

[WordPress Trac]

#53710: WP Update notice shown twice
---------------------------------------+-----------------------
 Reporter:  Presskopp                  |       Owner:  audrasjb
     Type:  defect (bug)               |      Status:  accepted
 Priority:  normal                     |   Milestone:  5.9
Component:  Upgrade/Install            |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  has-screenshots has-patch  |     Focuses:
---------------------------------------+-----------------------
Changes (by benjamingosset):

 * keywords:  needs-patch has-screenshots => has-screenshots has-patch


Comment:

 Hi,

 After taking a look to the {{{list_core_update()}}} function pointed by
 @audrasjb , it seems that the if statement on line 43 fails when
 {{{$update->locale}}} is 'en_US' and {{{get_locale()}}} is different than
 'en_US'. By the way, update button has the correct locale, only the
 message is wrong.

 I add an {{{elseif}}} statement (which works too with a {{{else}}}
 statement) to set  {{{$version_string}}} working for a non-en_US locale
 when displaying 'en_US' update.

 Could someone check if everything is ok ?

 Thanks

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53710#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform