[wp-trac] [WordPress Trac] #53363: Test tool and unit test improvements for 5.9

[WordPress Trac]

#53363: Test tool and unit test improvements for 5.9
--------------------------------------+---------------------
 Reporter:  desrosj                   |       Owner:  (none)
     Type:  task (blessed)            |      Status:  new
 Priority:  normal                    |   Milestone:  5.9
Component:  Build/Test Tools          |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+---------------------

Comment (by SergeyBiryukov):

 Replying to [comment:93 desrosj]:
 > In [changeset:"51921" 51921]:
 > {{{
 > #!CommitTicketReference repository="" revision="51921"
 > Build/Test Tools: Modify the Slack notifications workflow to be a
 reusable one.

 It looks like this works for core commits, but breaks on PRs, see
 [https://github.com/WordPress/wordpress-
 develop/runs/3960574230?check_suite_focus=true this job] for example, or
 any subsequent PR to the `wordpress-develop` repo:
 {{{
 Run actions/github-script at 441359b1a30438de65712c2fbca0abe4816fa667
   with:
     script: const previous_runs = await
 github.rest.actions.listWorkflowRuns({
     owner: 'WordPress',
     repo: 'wordpress-develop',
     workflow_id: 3023044,
     branch: '1736/merge',
     per_page: 1,
     page: 2,
   });
   return previous_runs.data.workflow_runs[0].conclusion;

     github-token: ***
     debug: false
     user-agent: actions/github-script
     result-encoding: json
 (node:1870) [DEP0005] DeprecationWarning: Buffer() is deprecated due to
 security and usability issues. Please use the Buffer.alloc(),
 Buffer.allocUnsafe(), or Buffer.from() methods instead.
 TypeError: Cannot read property 'conclusion' of undefined
     at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions
 /github-
 script/441359b1a30438de65712c2fbca0abe4816fa667/dist/index.js:4942:56),
 <anonymous>:11:44)
     at processTicksAndRejections (internal/process/task_queues.js:93:5)
     at async main (/home/runner/work/_actions/actions/github-
 script/441359b1a30438de65712c2fbca0abe4816fa667/dist/index.js:4997:20)
 Error: Unhandled error: TypeError: Cannot read property 'conclusion' of
 undefined
 }}}

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/53363#comment:98>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform