[wp-trac] [WordPress Trac] #54261: KSES: Allow PDFs to be embeded as objects

WordPress Trac noreply at wordpress.org
Mon Oct 18 04:57:32 UTC 2021


#54261: KSES: Allow PDFs to be embeded as objects
-------------------------------------------------+-------------------------
 Reporter:  pento                                |       Owner:  pento
     Type:  enhancement                          |      Status:  assigned
 Priority:  normal                               |   Milestone:  5.9
Component:  Formatting                           |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |     Focuses:
  has-unit-tests needs-dev-note                  |
-------------------------------------------------+-------------------------
Changes (by pento):

 * keywords:  has-patch 2nd-opinion needs-testing has-unit-tests => has-
     patch 2nd-opinion needs-testing has-unit-tests needs-dev-note


Comment:

 Thanks for the testing and feedback!

 @peterwilsoncc: I've implemented the changes you recommended.

 @dd32: I agree with your points on potential breakage, there's a small
 risk, but I think it's highly unlikely.

 If someone is substantially changing the structure of `$allowedposttags`
 (and then restoring it in `wp_kses_allowed_html`, perhaps), that would be
 a totally unsupported use case. Same for if they're defining the
 `required` and `values` properties to mean something else.

 If a plugin is adding the `<object>` tag to `$allowedposttags`, the only
 supported use case would be to work with KSES' existing behaviour, so the
 plugin should continue to function as is.

 Just in case, however, I've flagged this ticket as needing a dev note, to
 ensure the changes are more widely disseminated.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54261#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list