[wp-trac] [WordPress Trac] #54279: Unescaped echo in wp-includes/general-template.php

[WordPress Trac]

#54279: Unescaped echo in wp-includes/general-template.php
------------------------------------+-------------------------------
 Reporter:  sabbirshouvo            |       Owner:  (none)
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  5.9
Component:  Login and Registration  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch               |     Focuses:  coding-standards
------------------------------------+-------------------------------
Changes (by mukesh27):

 * version:  trunk =>
 * component:  General => Login and Registration
 * milestone:  Awaiting Review => 5.9


Comment:

 Hi there, thanks for the ticket and patch!

 The patch looks good to me just one thought, For below three variable we
 used two times `esc_attr` can we assign escape value in single variable
 and pass it?

 `esc_attr( $args['form_id'] )`
 `esc_attr( $args['id_username'] )`
 `esc_attr( $args['id_password'] )`


 Moving to milestone `5.9`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54279#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform