[wp-trac] [WordPress Trac] #38231: Allow download_url to respect content-disposition header

WordPress Trac noreply at wordpress.org
Wed Oct 13 22:32:26 UTC 2021


#38231: Allow download_url to respect content-disposition header
--------------------------------------+------------------------------
 Reporter:  cklosows                  |       Owner:  johnjamesjacoby
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  5.9
Component:  HTTP API                  |     Version:  4.7
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------

Comment (by johnjamesjacoby):

 [https://core.trac.wordpress.org/attachment/ticket/38231/38231.4.diff
 38231.4.diff] evolves 3.diff with the following feedback from @costdev:

 * Prefer `data_` over `provider_` to match existing data pattern from
 other tests
 * Lower case `content-disposition` in our fake headers arrays, because
 `wp_remote_retrieve_header()` won't have the luxury of extending
 `Requests_Utility_CaseInsensitiveDictionary` in our filtered data

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/38231#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list