[wp-trac] [WordPress Trac] #54251: Twenty Twenty: Vertical buttons spacing on frontend dependent on margins

[WordPress Trac]

#54251: Twenty Twenty: Vertical buttons spacing on frontend dependent on margins
---------------------------+-----------------------------
 Reporter:  stacimc        |      Owner:  (none)
     Type:  defect (bug)   |     Status:  new
 Priority:  normal         |  Milestone:  Awaiting Review
Component:  Bundled Theme  |    Version:  trunk
 Severity:  normal         |   Keywords:
  Focuses:                 |
---------------------------+-----------------------------
 The vertical spacing of buttons in Twenty Twenty relies on overriding
 margins. This is not compatible with efforts to refactor the Buttons block
 to use `gap` to control vertical spacing in between buttons, rather than
 using margins https://github.com/WordPress/gutenberg/pull/34546.

 {{{

 .wp-block-button:not(.alignleft):not(.alignright) {
         margin-bottom: 30px;
         margin-top: 30px;
 }

 .wp-block-button {
         margin: 3rem 0;
 }
 }}}

 These styles will break with the linked gap refactor; the margins are
 overridden and the vertical spacing between buttons shrinks considerably.


 Proposed Solution: Remove the margin-based styling in Twenty Twenty and
 instead add a rule increasing the size of the row-gap.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54251>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform