[wp-trac] [WordPress Trac] #54166: Updating errors due to PHP timeouts

[WordPress Trac]

#54166: Updating errors due to PHP timeouts
-------------------------------------------------+-------------------------
 Reporter:  aristath                             |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch early dev-feedback needs-  |     Focuses:
  testing                                        |
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Replying to [comment:16 peterwilsoncc]:
 > Reopening this as I think r51899 will need to be reverted

 Yeah, now that I think of it, I also have some concerns with the function:
 * It does not use the `WP_Filesystem_*` methods, so the `rename()` call
 will only work if direct PHP file access is available.
 * The fallback to `copy_dir()` causes inconsistent behavior:
  * If the `rename()` call worked, the source directory is successfully
 renamed and does not need any further actions.
  * If the `rename()` call failed, the source directory is left behind and
 has to be cleaned separately.

 I wonder [51899] is still needed after [51902], or after getting to the
 bottom of the issue from comment:16.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54166#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform