[wp-trac] [WordPress Trac] #54181: Terms management screen shows bulk actions dropdown even if there are no terms

[WordPress Trac]

#54181: Terms management screen shows bulk actions dropdown even if there are no
terms
-------------------------------------------------+-------------------------
 Reporter:  swissspidy                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Taxonomy                             |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  good-first-bug has-patch commit      |     Focuses:
  has-screenshots                                |  administration
-------------------------------------------------+-------------------------

Comment (by SergeyBiryukov):

 Hi there, thanks for the patch!

 I have a minor note: the `@since` version for the `has_items()` methods
 should be 3.1.0 instead of 5.9.0, as it was introduced in WordPress 3.1,
 see [17026] / #15857.

 Otherwise, the patch seems simple enough and looks good for the approach
 it implements.

 However, I would like to take a slightly different approach here and
 implement what the `@todo` note says instead:
 > Populate `$this->items` in `prepare_items()`.

 That would allow us to remove the `has_items()` method override altogether
 and just use the parent method from the `WP_List_Table` class. It would
 also be more consistent with other list table classes.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54181#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform