[wp-trac] [WordPress Trac] #54181: Terms management screen shows bulk actions dropdown even if there are no terms
WordPress Trac
noreply at wordpress.org
Wed Oct 6 21:27:18 UTC 2021
#54181: Terms management screen shows bulk actions dropdown even if there are no
terms
-------------------------------------------------+-------------------------
Reporter: swissspidy | Owner: (none)
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 5.9
Component: Taxonomy | Version:
Severity: normal | Resolution:
Keywords: good-first-bug has-patch needs- | Focuses:
refresh | administration
-------------------------------------------------+-------------------------
Changes (by audrasjb):
* keywords: good-first-bug has-patch needs-testing => good-first-bug has-
patch needs-refresh
Comment:
Thanks for the patch @mattoakley!
I can see a couple issues in your patch:
- please generate it against the root directory (/wordpress-develop)
instead of the location of the file
- we need an `@since 5.9.0` mention in the `Total items` and `Determines
if the current screen has results` Docblocks
- we need an `@var int` mention in the `Total items` Docblock
The rest looks good to me 🙂
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54181#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list