[wp-trac] [WordPress Trac] #39258: Move bottom of options-permalink.php into Contextual Help

[WordPress Trac]

#39258: Move bottom of options-permalink.php into Contextual Help
---------------------------------------------+-----------------------------
 Reporter:  johnjamesjacoby                  |       Owner:  hellofromTonya
     Type:  enhancement                      |      Status:  reviewing
 Priority:  normal                           |   Milestone:  5.9
Component:  Permalinks                       |     Version:
 Severity:  normal                           |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by hellofromTonya):

 * owner:  (none) => hellofromTonya
 * status:  new => reviewing


Comment:

 [attachment:"39258.diff"] patch works as expected. There are 2 code review
 items that can be fixed during commit:

 * I'd recommend unsetting the new variable to remove it from the global
 space (as it's only needed for this specific task):
 {{{#!php
 get_current_screen()->set_help_sidebar( $help_sidebar_content );
 unset( $help_sidebar_content );
 }}}

 * The change `<?php else :` is flagged by WPCS as the `<?php` should be on
 its own line. The opening tag is redundant with the code above it (also
 PHP code). However, that pattern is already set. Refactoring it would be
 out-of-scope for this ticket.

 This patch is ready for commit. I'll get it committed shortly.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/39258#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform