[wp-trac] [WordPress Trac] #54208: Twenty Twenty-One: Social icons have duplicate height and width values

[WordPress Trac]

#54208: Twenty Twenty-One: Social icons have duplicate height and width values
-------------------------------------------------+-------------------------
 Reporter:  Max dAyala                           |       Owner:  (none)
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  5.9
Component:  Bundled Theme                        |     Version:  5.8.1
 Severity:  normal                               |  Resolution:
 Keywords:  needs-patch good-first-bug has-      |     Focuses:
  screenshots                                    |
-------------------------------------------------+-------------------------

Comment (by sabernhardt):

 To reproduce the error:
 1. Go to Appearance > Menus and create a new menu.
 2. Assign it to the Secondary menu location.
 3. Add custom links to your menu, including some with various social URLs.
 For example, you could use WordPress.com and/or WordPress.org.
 4. Save menu.
 5. Visit the site and view source for the footer markup.
 6. Observe that the width and height attributes are included twice for
 each SVG. (In Firefox, the duplicate attributes are highlighted in red.)

 The Secondary menu's `$social_icons` array needs editing in
 [https://github.com/WordPress/WordPress/blob/bb7a0cf33475b9872f893ac97c96ba569604ef8f
 /wp-content/themes/twentytwentyone/classes/class-twenty-twenty-one-svg-
 icons.php#L47-L86 classes/class-twenty-twenty-one-svg-icons.php].

 The primary navigation's open and close buttons do not have the duplicate
 attributes because the `$icons` array does not include the width and
 height for those graphics.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54208#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform