[wp-trac] [WordPress Trac] #54385: Fatal error uploading media on PHP8

[WordPress Trac]

#54385: Fatal error uploading media on PHP8
-------------------------------------------------+-------------------------
 Reporter:  stevegs                              |       Owner:
                                                 |  hellofromTonya
     Type:  defect (bug)                         |      Status:  closed
 Priority:  normal                               |   Milestone:  5.9
Component:  Media                                |     Version:  2.5
 Severity:  normal                               |  Resolution:  fixed
 Keywords:  php8 has-patch needs-dev-note has-   |     Focuses:
  unit-tests commit                              |
-------------------------------------------------+-------------------------

Comment (by Gomle):

 I am sorry if this does not fit in. I am not a developer.

 But I can confirm this bug, as I am in the middle of migrating from
 another platform to Woocommerce.

 I have run into this issue while importing thousands of products. Some of
 the productimages that are to be migrated have meta information, and they
 stall the import, but it don't tell me which ones it is.

 There is about 18500 product images.

 Here is a couple of the **many** images that stalls the import:
 [[image(https://www.dekorama.no/img/p/5/5/0/5/5505.jpg)]]
 [[image(https://www.dekorama.no/img/p/5/5/2/5/5525.jpg)]]

 Any suggestions to how I best can solve it?

 I have spent days not understanding why it stops - so any help would be
 appreciated, even if it is a "quick fix" for me right now, that won't do
 any good in the long term.

 Will perhaps this fix it for importing as well?

 Old line 844:

 {{{
 $meta['aperture'] = round( wp_exif_frac2dec( $exif['FNumber'] ), 2 );
 }}}


 New line 844:

 {{{
 $meta['aperture'] = round( (float) wp_exif_frac2dec( $exif['FNumber'] ), 2
 );
 }}}


 I am running WP 5.8.2, and Woocommerce 5.9.0
 Kadence theme.
 All other plugins are deactivated for the sake of trying to get the import
 to work.
 NO luck so far.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54385#comment:50>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform