[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0
WordPress Trac
noreply at wordpress.org
Thu Nov 25 11:34:59 UTC 2021
#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
Reporter: jrf | Owner:
| SergeyBiryukov
Type: task (blessed) | Status: reopened
Priority: normal | Milestone: 5.9
Component: External Libraries | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-dev-note php80 | Focuses:
php81 |
-------------------------------------------------+-------------------------
Comment (by jrf):
@dd32 I appreciate the concern, but Requests 2.0.0 has been released and
the discussion about the namespace was had publicly in that repo, in open
videocalls and in WP Slack months ago.
Input at the time would have been very welcome, but was not received and
it's too late to change this now.
The choice for the namespace was discussed extensively and various options
were considered during those discussions.
We originally were going to use just `Requests\` as the "prefix", but that
was causing problems with the BC-layer. In our opinion, including the BC-
layer was imperative to allow for plugins supporting multiple versions of
WP and using parts of Requests directly, so that meant we had to
reconsider the namespace.
We considered using `WordPress\Requests\`, but as Requests is a stand-
alone project, we did not want to create a situation were the namespace
chosen by Requests could ever become a blocker for WordPress itself
adopting namespaces at some point in the future.
We also considered that Requests is used by more projects than just
WordPress and that the namespace prefix should not cause undue friction in
other projects using Requests, so we ended up compromising on
`WpOrg\Requests\`.
While it is, of course, perfectly possible to change it for the copied
version included in WP, this would make all future merges of Requests a
lot more complex, so I'd strongly recommend against that.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list