[wp-trac] [WordPress Trac] #54504: Update Requests library to version 2.0.0

WordPress Trac noreply at wordpress.org
Thu Nov 25 02:11:59 UTC 2021


#54504: Update Requests library to version 2.0.0
-------------------------------------------------+-------------------------
 Reporter:  jrf                                  |       Owner:
                                                 |  SergeyBiryukov
     Type:  defect (bug)                         |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  External Libraries                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-dev-note php80       |     Focuses:
  php81                                          |
-------------------------------------------------+-------------------------
Changes (by SergeyBiryukov):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:8 dd32]:
 > Can we consider renaming the namespace from `WpOrg` to something more
 generic, such as `WordPress` or `WP`?
 >
 > That appears to be the first WordPress-specific namespace used within
 WordPress, and setting the name as `WpOrg` seems like it might be rather
 ugly later on.

 Thanks for bringing this up! That was my concen here too, but I didn't
 want it to block the merge.
 >
 > The inclusion of `Org` is also kind of close to the namespace used on
 WordPress.org of `WordPressdotorg`.. So if this was intended on being "Not
 WordPress, but a WordPress.org thing" then that longer format may have
 been more appropriate, I'm not sure.
 >
 > I realise this has been something that has been decided "upstream" in
 Requests, but raising this here since it's where the merge has happened.

 For reference, it appears to be implemented in this PR:
 [https://github.com/WordPress/Requests/pull/519 Requests 2.0.0: introduce
 namespaces]:
 > Acronyms are "proper cased", i.e. first character uppercase, the rest of
 the acronym lowercase.
 See [https://github.com/WordPress/Requests/pull/519#issuecomment-917328050
 this comment] specifically for more details.

 Either `WordPressdotorg` or `WPorg` would be my preference too, though it
 slightly deviates from the "proper cased" rule used for other acronyms.
 Could it perhaps be an exception?

 Reopening for discussion.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54504#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list