[wp-trac] [WordPress Trac] #54060: kses.php global $allowedxmlentitynames naming

[WordPress Trac]

#54060: kses.php global $allowedxmlentitynames naming
--------------------------------------+-----------------------------
 Reporter:  ovidiul                   |       Owner:  SergeyBiryukov
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  5.9
Component:  Formatting                |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+-----------------------------

Comment (by SergeyBiryukov):

 Thanks for the PR! This looks good to me, I only have two minor notes:
 * For consistency with the existing `$allowedentitynames` variable, I
 think it would be better to standardize on `$allowedxmlentitynames` here,
 instead of `$allowedxmlnamedentities`.
 * The `null` array key should probably be `empty string`, to avoid
 confusion with an actual `null` value, which is not being tested here.

 I can make these adjustments on commit.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54060#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform