[wp-trac] [WordPress Trac] #54421: Deprecate skip link focus fix

WordPress Trac noreply at wordpress.org
Fri Nov 19 20:04:27 UTC 2021


#54421: Deprecate skip link focus fix
-------------------------+-------------------------------------------------
 Reporter:  westonruter  |       Owner:  westonruter
     Type:  enhancement  |      Status:  accepted
 Priority:  low          |   Milestone:  6.0
Component:  Bundled      |     Version:  3.6
  Theme                  |
 Severity:  minor        |  Resolution:
 Keywords:  has-patch    |     Focuses:  accessibility, javascript,
                         |  performance
-------------------------+-------------------------------------------------
Changes (by sabernhardt):

 * type:  defect (bug) => enhancement
 * milestone:  5.9 => 6.0


Comment:

 This does not need to be changed immediately. Besides, I think removing
 the (legacy) IE conditional code could give more of a performance
 improvement for the older themes.

 Twenty Twenty-One uses the `$is_IE` variable to determine whether to
 enqueue the IE stylesheet instead of the one with custom CSS properties.
 So if page caching breaks the browser detection, that theme would have a
 bigger problem than printing a 350-byte script for only a small number of
 people. And if someone needs the script but caching would remove it,
 asking the site owner to disable page cache should be easier than asking
 them to create a child theme that reinstates the script (or even to
 install another plugin for it).

 Twenty Thirteen and Twenty Fourteen might be better to keep as they are.
 Including a deprecation notice is just adding more to the script fileā€”and
 changing its modified date. Plus, I don't know if moving it outside of
 functions.js could help at all.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54421#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list