[wp-trac] [WordPress Trac] #51857: Add rollback for failed plugin/theme updates

[WordPress Trac]

#51857: Add rollback for failed plugin/theme updates
-------------------------------------------------+-------------------------
 Reporter:  pbiron                               |       Owner:  pbiron
     Type:  enhancement                          |      Status:  reopened
 Priority:  normal                               |   Milestone:  5.9
Component:  Upgrade/Install                      |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  early has-testing-info needs-unit-   |     Focuses:
  tests needs-testing has-patch                  |
-------------------------------------------------+-------------------------

Comment (by pbiron):

 Replying to [comment:172 dlh]:
 > After [51815], a database error occurs when installing WordPress from
 `wp-admin/install.php` because there's an attempt to write the `cron`
 option.
 >
 > A `! wp_installing()` check inside
 `\WP_Upgrader::schedule_temp_backup_cleanup()` might be all that's needed,
 but I'm not familiar enough with the changes in this ticket to be sure
 whether it's the right approach.

 Good catch @dlh .

 [attachment:"51857.7.diff"] fixes the problem.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/51857#comment:173>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform