[wp-trac] [WordPress Trac] #54443: Database Error Breaks "custom_css_post_id" Theme Mod

[WordPress Trac]

#54443: Database Error Breaks "custom_css_post_id" Theme Mod
---------------------------+------------------------------
 Reporter:  domainsupport  |       Owner:  (none)
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Customize      |     Version:  4.7
 Severity:  normal         |  Resolution:
 Keywords:  close          |     Focuses:
---------------------------+------------------------------
Changes (by dlh):

 * keywords:   => close
 * focuses:  css, administration =>
 * version:  trunk => 4.7


Comment:

 Adding the condition at that location would mean, I think, that the "no
 custom CSS" state wouldn't be cached during normal database operations,
 causing unnecessary lookups on subsequent requests. If so, I'm not sure
 that the performance cost is worth the potential benefit.

 Additionally, is there something about the custom CSS logic in question
 that makes it likely to be running when database issues occur? Database
 blips would be indiscriminate in the code they affect, I would think. I'm
 not sure that it's clear why this location in particular deserves extra
 checks.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54443#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform