[wp-trac] [WordPress Trac] #54405: Disable Gutenberg 11.8.2 (and likely earlier) upon upgrade to WordPress 5.9

[WordPress Trac]

#54405: Disable Gutenberg 11.8.2 (and likely earlier) upon upgrade to WordPress 5.9
-------------------------------------+-----------------------------
 Reporter:  jorbin                   |       Owner:  hellofromTonya
     Type:  task (blessed)           |      Status:  reviewing
 Priority:  normal                   |   Milestone:  5.9
Component:  Upgrade/Install          |     Version:
 Severity:  blocker                  |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:
-------------------------------------+-----------------------------

Comment (by hellofromTonya):

 = Test Report

 env:
 * OS: macOS
 * localhost: Local
 * Plugins: Beta Tester, Core Rollback, Gutenberg (various versions)
 * Browser: Firefox, Chrome, Safari, Edge (though browser doesn't really
 matter)

 == Steps

 Note: You can download different Gutenberg plugin versions from here
 https://wordpress.org/plugins/gutenberg/advanced/

 1. Start with WordPress 5.8.2
 2. Install Gutenberg 11.7 (which also has the `WP_Theme_JSON_Schema`
 interface conflict in it) and activate it
 3. Go to Tools > Beta Testing and set these settings: "Bleeding edge" and
 "Nightlies". Press save.
 4. Go to Dashboard > Updates
 5. Click the "Update to latest 5.9 nightly" blue button

 Result: 5.9 installs, no fatal error, and Gutenberg plugin is deactivated
 (check by going to Plugins)

 6. Roll WordPress back to 5.8.2 by going to Dashboard > Updates and
 clicking the "Re-install version on 5.8.2" button.
 7. Go to Plugins and delete the Gutenberg plugin.
 8. Install and activate Gutenberg 11.8.0.
    * Click "Add New" and then "Upload Plugin". Drag and drop or select the
 11.8.0 version of the Gutenberg plugin.
    * Click "Install Now".
    * Once installed, click to activate it.
 9. Repeat steps 4 and 5.

 Results: Fatal error.

 Bummer. Why? The `version_compare()` of `<= 11.8` doesn't work when the
 version is 11.8.x. See it in action here https://3v4l.org/BGVJo.

 [attachment:"54405.diff"] changes to use `< 11.9` for the
 `version_compare()`.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54405#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform