[wp-trac] [WordPress Trac] #54405: Disable Gutenberg 11.8.2 (and likely earlier) upon upgrade to WordPress 5.9
WordPress Trac
noreply at wordpress.org
Wed Nov 17 14:19:40 UTC 2021
#54405: Disable Gutenberg 11.8.2 (and likely earlier) upon upgrade to WordPress 5.9
-------------------------------------+-----------------------------
Reporter: jorbin | Owner: hellofromTonya
Type: task (blessed) | Status: reviewing
Priority: normal | Milestone: 5.9
Component: Upgrade/Install | Version:
Severity: blocker | Resolution:
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+-----------------------------
Comment (by hellofromTonya):
Replying to [comment:9 TobiasBg]:
> Is it actually necessary to call (and even keep)
`_upgrade_580_force_deactivate_incompatible_plugins()` in trunk (i.e. WP
5.9+)?
> If Gutenberg is so old that it would be deactivated in
`_upgrade_580_force_deactivate_incompatible_plugins();`, it would also be
deactivated by `_upgrade_590_force_deactivate_incompatible_plugins();`
that is called in the next line.
> Thus, we can save a few if comparisons during the core upgrade, which
can never hurt.
>
> As long as `_upgrade_580_force_deactivate_incompatible_plugins()` stays
in the WP 5.8.x branch (which it will, due to the SVN branch), everything
should be fine, I believe?
>
> (Moving the plugin deactivation code to a private function would also
not really be needed then, either.)
Hmm, good points @TobiasBg. I agree.
`_upgrade_580_force_deactivate_incompatible_plugins()` was deactivating
Gutenberg only. As this is an upgrade for 5.9.0 (with 5.8 in a separate
branch), this function can renamed for `590`.
Then it can be renamed for each future release with the appropriate
compatible/incompatible Gutenberg plugin versions.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/54405#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list