[wp-trac] [WordPress Trac] #46748: authenticate filter hook does not behave as expected for priority values less than 20
WordPress Trac
noreply at wordpress.org
Wed Nov 17 01:23:20 UTC 2021
#46748: authenticate filter hook does not behave as expected for priority values
less than 20
----------------------------------------------+----------------------------
Reporter: robert.peake | Owner:
| SergeyBiryukov
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 6.0
Component: Login and Registration | Version: 3.7
Severity: normal | Resolution:
Keywords: has-unit-tests early needs-patch | Focuses:
----------------------------------------------+----------------------------
Changes (by hellofromTonya):
* keywords: has-patch has-unit-tests early => has-unit-tests early needs-
patch
Comment:
Hold on. In testing further, [attachment:"46748.diff"] blocks email login
in `wp_authenticate_email_password()`. The PR adds an `is_email()` check.
This needs further investigation to determine if the changes are
appropriate or if something else is going on. I agree with
@TimothyBlynJacobs to punt this to 6.0. Give it time for more discussion
and investigation.
Marking as `needs-patch` as the current patches do not fully resolve the
reported issue: i.e. works for username login, but not email login.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/46748#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list