[wp-trac] [WordPress Trac] #54385: Fatal error uploading media on PHP8

[WordPress Trac]

#54385: Fatal error uploading media on PHP8
----------------------------+------------------------------
 Reporter:  stevegs         |       Owner:  adamsilverstein
     Type:  defect (bug)    |      Status:  assigned
 Priority:  normal          |   Milestone:  5.9
Component:  Media           |     Version:  2.5
 Severity:  normal          |  Resolution:
 Keywords:  php8 has-patch  |     Focuses:
----------------------------+------------------------------

Comment (by adamsilverstein):

 > It seems that your latest patches contain a few other code changes as
 well, that are unrelated?


 Oops, rebased to trunk, let me fix that diff

 > if ( 0 === $denominator ) {

 makes sense for consistency, will change.

 I also switched back to using `empty` which is more consistent for PHP 7.

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/54385#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform