[wp-trac] [WordPress Trac] #42979: Draw "dismiss" icon in upload errors in the error div, not after the action title

WordPress Trac noreply at wordpress.org
Tue Nov 16 18:28:59 UTC 2021


#42979: Draw "dismiss" icon in upload errors in the error div, not after the action
title
--------------------------+------------------------------------------------
 Reporter:  ComputerGuru  |       Owner:  joedolson
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  5.9
Component:  Media         |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  ui, accessibility, administration
  needs-testing           |
--------------------------+------------------------------------------------
Changes (by shaunandrews):

 * keywords:  has-patch needs-testing needs-design-feedback => has-patch
     needs-testing


Comment:

 > Definitely in favor of greater simplification, though I think that we
 should avoid using default button styles; that doesn't seem consistent
 with the rest of the core WordPress design. It should probably use
 '.button', at a minimum. Thoughts?

 Ah yes, of course. That was my intention but I obviously made some false-
 assumptions about how the CSS is applied. Thanks to @sabernhardt for
 updating the diff to include the proper class name. Looks good to me!

-- 
Ticket URL: <https://core.trac.wordpress.org/ticket/42979#comment:34>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list